Thursday, 18 May 2017

ES6 promises and ElasticSearch

I just started using ElasticSearch in Node/Express, and not being an experienced JavaScript/ES6 developer I'm a bit confused by Promises.

The situation is as follows: I receive a request which includes one or more query parameters. These need to be translated to an ElasticSearch query. Some of the query parameters can readily be translated in a (part of the) ElasticSearch query, some others require longer running tasks such as querying another ElasticSearch index.

This is what I have in my service layer for now:

const find = function(q) {
    return generateElasticQuery(q).then(function(elasticQuery) {
        return model.find(elasticQuery)
    })
}

where q contains the query parameters from the GET request.

In generateElasticQuery I initiate a query object and then modify it using a a number of functions:

const generateElasticQuery = function(q) {
    let elasticQuery = { "term": {} }
    return Promise.all([
        processParameterA(q, elasticQuery),
        processParameterB(q, elasticQuery)
    ]).then(function() {
        return elasticQuery
    })
}

These functions look somewhat like this:

const processParameterA = function(q, elasticQuery) {
    return new Promise(function(resolve, reject) {
        if (q.parameterA) {
            someOtherAsyncTask(q.parameterA).then(function(res) {
                // modify elasticQuery
                resolve()
            })
        } else {
            resolve()
        }
    })
}

const processParameterB = function(q, elasticQuery) {
    return new Promise(function(resolve, reject) {
       // nothing to be done for now
       resolve()
    })
} 

This all seems to work but it doesn't feel quite right. Is there a better approach for this situation?



via user3170702

No comments:

Post a Comment